dev/core#1983 Fix to tax calculation on multi-line-item
authoreileen <emcnaughton@wikimedia.org>
Sun, 30 Aug 2020 22:10:35 +0000 (10:10 +1200)
committereileen <emcnaughton@wikimedia.org>
Mon, 31 Aug 2020 01:18:14 +0000 (13:18 +1200)
commitdfdee38776797b83b6d970fd4042740bde1186eb
tree096b940fe9a6d1f017d6b54d18d3743a785e4507
parent85381a514f6cdd184b5751829caaa527afb4fab4
dev/core#1983 Fix to tax calculation on multi-line-item

This is similar to https://github.com/civicrm/civicrm-core/pull/18284 - it differs in that the totals are calculated by iterating
through the line item array afterwards, rather than expecting the 'getLine' function to calculate totals. Some
obvious follow ups suggest themselves but I will look against master.

This is difficult to test (Karin gave it a really good shot) because of the weird way it's calculated in Main and thenn
used in Confirm. Cleanup should resolve the testability issue too
CRM/Price/BAO/LineItem.php
CRM/Price/BAO/PriceSet.php
tests/phpunit/CRM/Event/BAO/ChangeFeeSelectionTest.php
tests/phpunit/CRM/Member/Form/MembershipTest.php