Fix Payment.create to update financial_item.status_id
authorEileen McNaughton <emcnaughton@wikimedia.org>
Fri, 23 Jul 2021 23:24:46 +0000 (11:24 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Wed, 28 Jul 2021 00:59:41 +0000 (12:59 +1200)
commitde7391fc1cb9b2722a6b0f129a741b5395f7a032
tree0baf2fd0e28a614c00c7aa091ba379a3e01432a6
parent60e5cf3432f2aed4768645c9ab9eb1399e3345c9
Fix Payment.create to update financial_item.status_id

When I try to switch to the order->create flow for membership forms it turns
out we are leaving the financial_item.status_id as 'unpaid' when adding a payment.

No one has noticed because this field is kinda unused - but it needs to work
to pass tests
CRM/Financial/BAO/Payment.php
tests/phpunit/CRM/Contribute/BAO/ContributionTest.php
tests/phpunit/CRM/Event/Form/ParticipantTest.php
tests/phpunit/api/v3/ContributionTest.php
tests/phpunit/api/v3/OrderTest.php