projects / civicrm-core.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 28888d8) | patch
Clean up & clarify code splitting line items in Contribution page membership flow
authorEileen McNaughton <emcnaughton@wikimedia.org>
Tue, 21 Nov 2023 21:53:46 +0000 (10:53 +1300)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Wed, 22 Nov 2023 00:07:45 +0000 (13:07 +1300)
commitd9ee1483563c8853d0b5020ea4a17e5cb218ac24
tree058e9c8f20fde31c6d001fc1fe28d23c72165b7etree | snapshot (zip tar.gz)
parent28888d8a030a0086489b8d54d8c1565047b67a99commit | diff
Clean up & clarify code splitting line items in Contribution page membership flow

It was really confusing - but now it is separated into a function which explains it

Note there is specic test cover in
testSubmitMembershipComplexPriceSetPaymentPaymentProcessorRecurInstantPayment
and the changes to that test reflects the fact that the order in which
the line items are created changes slightly (in a fundamentally neutral way
CRM/Contribute/Form/Contribution/Confirm.php diff | blob | blame | history
CRM/Financial/BAO/Order.php diff | blob | blame | history
tests/phpunit/api/v3/ContributionPageTest.php diff | blob | blame | history