[REF] simplify retrieval of existing membership on membership renewal form
authoreileen <emcnaughton@wikimedia.org>
Mon, 31 Aug 2020 04:42:15 +0000 (16:42 +1200)
committereileen <emcnaughton@wikimedia.org>
Mon, 31 Aug 2020 04:42:15 +0000 (16:42 +1200)
commitd7d9f7b6621fefc1f4e53787933d870f4e37c4da
tree078384068588d5aac73535ebda621dc7e00fc14a
parent060f4f65044c7cb305b9abda7af101d59c72850a
[REF] simplify retrieval of existing membership on membership renewal form

After stepping through the code I determined that if membershipID is passed into getContactMembership then it either
1) returns the membership id much like membership.get but with is_current_member calculated or
2) returns the owner membership in a similar format

However, the renewal form is not visible for a non-owner membership so getting the owner membership is cruft
from another form & only 1 applies. Calling the api is much more transparent
CRM/Member/Form/MembershipRenewal.php