CRM-16373 - Search Settings - Fix dupes (eg contact_reference_options/autocompleteCon...
authorTim Otten <totten@civicrm.org>
Wed, 9 Sep 2015 06:18:34 +0000 (23:18 -0700)
committerTim Otten <totten@civicrm.org>
Thu, 17 Sep 2015 22:49:29 +0000 (15:49 -0700)
commitd434f797170a1813e26a1ff000ea334d4487fd19
tree1690180ec7298ab49a74ec7eda786a82e1469c93
parentb72b5fc077827dab95096f9cbaa7bf477fe17ab9
CRM-16373 - Search Settings - Fix dupes (eg contact_reference_options/autocompleteContactReference)

Note:
 * The `autocompleteContactReference` and `autocompleteContactSearch` settings don't seem to be really stored as such.
 * The form includes various hacks which effectively saves these fields in `contact_reference_options` and `contact_autocomplete_options`.
 * At runtime, the application logic checks for `contact_reference_options` and `contact_autocomplete_options`.
 * This situation predates the declarations of `autocompleteContactReference` and `autocompleteContactSearch` in `Search.setting.php`. It seems likely
   that these settings have never been useful.

The fields still have some hacks, but they should be a bit easier to read/trace/grep.
CRM/Admin/Form/Setting.php
CRM/Admin/Form/Setting/Search.php
CRM/Core/BAO/ConfigSetting.php
settings/Core.setting.php
settings/Search.setting.php
templates/CRM/Admin/Form/Setting/Search.tpl