dev/core#3038 Fix handling for payment_instrument_id, cleanup financial_type_id
authorEileen McNaughton <emcnaughton@wikimedia.org>
Wed, 25 May 2022 22:14:33 +0000 (10:14 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Thu, 26 May 2022 02:54:52 +0000 (14:54 +1200)
commitcbc11a3740ec37c76ad3970218a3ce7e35852ea9
tree4535698d8ec0614bd4a8dacbd7b317725ee1715c
parentc7855eadf4eb4905142210b8c1d4886ce33409aa
dev/core#3038 Fix handling for payment_instrument_id, cleanup financial_type_id

This addresses https://lab.civicrm.org/dev/core/-/issues/3038
by getting rid of the non-standardness around payment_instrument_id
and financial_type_id. The two fields are now
marked as importable and we use the
real names (payment_instrument_id) rather than the
'handy-dandy' names (payment_instrument) - which means
we can simplify in a bunch of places. Also since we are
already cleaning up names in the upgrade we add these in there
CRM/Contribute/BAO/Contribution.php
CRM/Contribute/DAO/Contribution.php
CRM/Contribute/Import/Form/MapField.php
CRM/Contribute/Import/Parser/Contribution.php
CRM/Core/OptionValue.php
CRM/Import/Parser.php
CRM/Upgrade/Incremental/php/FiveFiftyOne.php
tests/phpunit/CRM/Contribute/Import/Parser/ContributionTest.php
xml/schema/Contribute/Contribution.xml