[REF] extract buildClause from CRM_Report_Form_Event_Income
authoreileen <emcnaughton@wikimedia.org>
Sun, 21 Apr 2019 02:29:37 +0000 (12:29 +1000)
committereileen <emcnaughton@wikimedia.org>
Sun, 21 Apr 2019 02:30:11 +0000 (12:30 +1000)
commitc442c8509f5eab86079ea44b586368cdb953d7f9
tree0adfd9e00ee542764fbf95140dd6493bcd56f89c
parent2617d8428fbda5e93ae84395d1fb931e9a5c166f
[REF] extract buildClause from CRM_Report_Form_Event_Income

This report is currently excluded from unit tests by virtue of it being declared as skipped in
api_v3_ReportTemplateTest

We have a PR https://github.com/civicrm/civicrm-core/pull/13928 to alter test logic.

I'm really not comfortable making any logic changes to the report until
it is under testing. Extracting buildQuery removes one of the blockers to
bringing it under testing (remaining are moving most / all logic from
postProcess to beginPostProcessCommon and fixing up the setPager function -
which probably just means removing it
CRM/Report/Form/Event/Income.php