dev/financial#152 simplify interaction with membership, deprecate function
authoreileen <emcnaughton@wikimedia.org>
Sun, 11 Oct 2020 20:36:18 +0000 (09:36 +1300)
committereileen <emcnaughton@wikimedia.org>
Sun, 11 Oct 2020 20:42:54 +0000 (09:42 +1300)
commitc3407e4e827790203f3db21133e6806e2a5b1188
treee26e2abb18c99a7c1f7e3003f61178ffa4c58a62
parente5c67186c08a020d4b3b8693dd4e1e178c6a6b70
dev/financial#152 simplify interaction with membership, deprecate function

ids['membership'] is only calculated in the Authorize.net IPN flow for the purpose of determining
the autoRenew membership parameter for recurringNotify. This is currently passed to sendRecurringStartOrEndNotification
but that does not add any simplification & cannot be used elsewhere - so deprecating.

This is tested in testIPNPaymentMembershipRecurSuccessNoLeakage
CRM/Contribute/BAO/ContributionRecur.php
CRM/Core/Payment/AuthorizeNetIPN.php
tests/phpunit/CRM/Core/Payment/AuthorizeNetIPNTest.php