dev/core#942 fix failure to render names for some activities
authoreileenmcnaugton <emcnaughton@wikimedia.org>
Fri, 10 May 2019 04:13:11 +0000 (16:13 +1200)
committereileenmcnaugton <emcnaughton@wikimedia.org>
Sat, 11 May 2019 03:11:36 +0000 (15:11 +1200)
commitc2ce41b6fead1dbf950c2e11ed07688ec31ca23b
treed34ccd25744d7690686870975ae9b7ffe8a6ba62
parentc7f99cf86696e1adf2ebe425050d07643bcc93cc
dev/core#942 fix failure to render names for some activities

Overview
----------------------------------------
Set limit for activity_contact retrieval to 0, allowing to retrieve more than 25 activity contacts when rendering the first 25 activities on the activity contact tab

Before
----------------------------------------
![before](https://user-images.githubusercontent.com/336308/57439801-e42a0580-729a-11e9-80a1-45df93d0c5eb.jpg)

After
----------------------------------------
![after](https://user-images.githubusercontent.com/336308/57439960-39fead80-729b-11e9-9701-acd79ff73497.jpg)

Technical Details
----------------------------------------
This moves the logic for retrieving the target contacts back into the getActivities function. We are stil not wanting to bypass the ACLs so still using the
api but strictly limiting the number of contacts we retrieve (at the cost of extra queries, but cheap ones).

Some tests added on the Bulk Mail activity.

Comments
----------------------------------------
CRM/Activity/BAO/Activity.php
api/v3/Activity.php
tests/phpunit/CRM/Activity/BAO/ActivityTest.php