CRM-20420 - PDFLetterCommon::createActivities() - Simplify. Address comment.
authorTim Otten <totten@civicrm.org>
Wed, 12 Apr 2017 05:42:22 +0000 (22:42 -0700)
committerTim Otten <totten@civicrm.org>
Wed, 12 Apr 2017 21:07:47 +0000 (14:07 -0700)
commitc2c77efd1f5bceb0b6a3aba8c1d4987502111245
treeb404924ff57234e7cd6fe642d5522292a1e4c212
parentd0e1473097276e24e69e28c58ea339df2bf32a75
CRM-20420 - PDFLetterCommon::createActivities() - Simplify. Address comment.

The comment asks why the code appears to use of `$contactIds` and
`$form->contactIds` interchangeably.  If you grep for calls to
`createActivities()`, all 3-ish callpaths do set `$contactIds` based on
`$form->contactIds` -- so they are the same.

```
// Look for calls to createActivities()
$ grep -r ::createActivities CRM/ Civi/ api/
CRM/Contact/Form/Task/PDFLetterCommon.php:      self::createActivities($form, $html_message, $form->_contactIds);
CRM/Member/Form/Task/PDFLetterCommon.php:    self::createActivities($form, $html_message, $contactIDs);
CRM/Contribute/Form/Task/PDFLetterCommon.php:    self::createActivities($form, $html_message, $form->_contactIds);

// Look for calls to createActivities via CRM/Member/Form/Task/PDFLetterCommon

$ rgrep -r postProcessMembers\( CRM/ Civi/ api/
CRM/Member/Form/Task/PDFLetter.php:    CRM_Member_Form_Task_PDFLetterCommon::postProcessMembers(
CRM/Member/Form/Task/PDFLetterCommon.php:  public static function postProcessMembers(&$form, $membershipIDs, $skipOnHold, $skipDeceased, $contactIDs) {
```
CRM/Contact/Form/Task/PDFLetterCommon.php