[REF] Simplification in Contact::getValues
authorEileen McNaughton <emcnaughton@wikimedia.org>
Sat, 12 Feb 2022 03:31:56 +0000 (16:31 +1300)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Sat, 12 Feb 2022 03:33:41 +0000 (16:33 +1300)
commitba6f8b4ceac104c681f2e648142ce4edf73c1951
treefb9390bc2a5c74ab36cd2c22828b65db595e5b20
parent5b1e5bf9c924378c9783b7f6eb4e7c4fedb61caf
[REF] Simplification in Contact::getValues

The call to location::getValues takes more lines & is
less readable than just doing the thing.

Note that
1) I could not find any evidence of 'noWebsite' being passed in so I switched to
always add
2) the signature on website:getValues is slightly different (of course).
3) I found that the others that were receiving params as a reference were
not altering it so removed those pass-by-refs
CRM/Contact/BAO/Contact.php
CRM/Contact/BAO/GroupContact.php
CRM/Contact/BAO/Relationship.php
CRM/Core/BAO/Note.php
CRM/Core/BAO/Website.php