Replace use of contributeMode with alternatives
authorEileen McNaughton <emcnaughton@wikimedia.org>
Tue, 7 Nov 2023 23:03:20 +0000 (12:03 +1300)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Wed, 8 Nov 2023 00:34:10 +0000 (13:34 +1300)
commitb94ff7f078556b04ddc9fd44892852576f6b17da
tree11a9ef07ebb06131d364f37226f59ea88331bd9d
parent4bd3f824e45a0120ea4f6190f1bd30705f2d6859
Replace use of contributeMode with alternatives

This addresses 2 places contributeMode is used

1)  CRM_Contribute_BAO_Contribution::createAddress does not require this check - it
works by checking if there are appropriate params from the billing profile - which
will have been displayed on the form or not as required by the processor

2) Replaces a specific check for paypal express with a check specific to that
class name. In the process functions are added for getPaymentProcessorValue()
in keeping with recently added getEventValue() getParticipantValue() etc
CRM/Core/Form.php
CRM/Event/Form/Registration.php
CRM/Event/Form/Registration/Confirm.php
CRM/Event/Form/Registration/Register.php
CRM/Financial/Form/PaymentProcessorFormTrait.php