[REF] Clean up on ids['contribution']
authoreileen <emcnaughton@wikimedia.org>
Mon, 14 Dec 2020 05:35:51 +0000 (18:35 +1300)
committereileen <emcnaughton@wikimedia.org>
Mon, 14 Dec 2020 05:35:51 +0000 (18:35 +1300)
commitb9108561d20c254ba72bdb6056e85406bc0aaa2f
treef77a01c13f8d90d9d0925ccc12ff724893674806
parentce881610719ee8ed5dfbf6b977242ab3d5bc1b0e
[REF] Clean up on ids['contribution']

This removes ids['contribution'] and uses the simpler variable contributionID
In addition 2 if clauses are wrapped in if (contributionID) to make it clear
that both are only reachable when there is no contributionID
CRM/Member/BAO/Membership.php