APIv4 - Delete unused OptionList trait
authorColeman Watts <coleman@civicrm.org>
Mon, 29 Nov 2021 13:50:03 +0000 (08:50 -0500)
committerColeman Watts <coleman@civicrm.org>
Mon, 29 Nov 2021 13:50:03 +0000 (08:50 -0500)
commitb35f59345056cf605927f24d75e610db599838ab
treedc44d16218abc5925f22000a007755c23b92a2f2
parent2031271ca6688a49ec12c3d7b0db0fb264665f23
APIv4 - Delete unused OptionList trait

This trait had been added for the sake of SearchKit to determine which entities should be
searchable and which were merely supplying option lists for other entities.

However, this logic broke down quickly as some option lists *should* be searchable,
so that path was abandoned in favor of the `@searchable` annotation.

The trait now does nothing and is just taking up space and adding unnecessary complexity.
17 files changed:
Civi/Api4/CaseType.php
Civi/Api4/ContactType.php
Civi/Api4/Country.php
Civi/Api4/Entity.php
Civi/Api4/FinancialType.php
Civi/Api4/Generic/Traits/OptionList.php [deleted file]
Civi/Api4/LocationType.php
Civi/Api4/MembershipBlock.php
Civi/Api4/MembershipStatus.php
Civi/Api4/MembershipType.php
Civi/Api4/OptionGroup.php
Civi/Api4/OptionValue.php
Civi/Api4/PaymentProcessor.php
Civi/Api4/PaymentProcessorType.php
Civi/Api4/PaymentToken.php
Civi/Api4/RelationshipType.php
Civi/Api4/StateProvince.php