CRM-16138 - CRM_Extensions_System - Include domain_id in cache paths
authorTim Otten <totten@civicrm.org>
Fri, 3 Apr 2015 00:09:53 +0000 (17:09 -0700)
committerTim Otten <totten@civicrm.org>
Fri, 3 Apr 2015 00:09:53 +0000 (17:09 -0700)
commitadada47212c7fad0d343cf8b2c60fdc87266a811
treed6ca7ded41e60ef9bb3e452b633c0ccdcbc10952
parent8da4d19481a1495317806f83dc29a3ca6c8c87f1
CRM-16138 - CRM_Extensions_System - Include domain_id in cache paths

The extension cache (returned by CRM_Extension_System::getCache) is already
keyed off extensionDir, extensionUrl, civicrm_root, and several others.
This patch adds domain_id to the list.

The patch is derived from agileware's patch from 4.4. Notably, the original
patch only influenced mapper (not the other caches).

I don't really think this patch should be necessary. Firstly, there are
already many variables factored into the cache-key for 4.6+ (CRM-15788) --
one (or more) should get tripped in "single-database, multiple-codebase"
architecture.  Secondly, the extension list is not innately domain-based.

However, there are a dizzying range of variations on
multi-site/multi-domain, and I may not have a full appreciation for the one
that led to agileware's patch.  And (theoertically) there's no big downside
to including domain_id as part of the cache.
CRM/Extension/System.php