[REF] Clean up code around is_email_receipt
authoreileen <emcnaughton@wikimedia.org>
Sat, 6 Mar 2021 19:56:55 +0000 (08:56 +1300)
committereileen <emcnaughton@wikimedia.org>
Sat, 6 Mar 2021 19:56:55 +0000 (08:56 +1300)
commitaa16240e0bab17b980bd4ab3d32bd20cfa2f1461
treebeec7e144641ce091dc3b0310bc5467d1f7cd454
parent27dff1b5c085370f8ebd712f61431fa87491ecbd
[REF] Clean up code around is_email_receipt

The is_email_receipt param is passed into legacyProcessRecurringContribution
but not used. It is also used to set now to receipt date which is then
only used in a loop that uses a more direct method to check
if an email receipt is used.
CRM/Member/Form/Membership.php