[REF] Fix Event location to create it's locations directly rather than via shared...
authoreileen <emcnaughton@wikimedia.org>
Thu, 24 Sep 2020 23:01:09 +0000 (11:01 +1200)
committereileen <emcnaughton@wikimedia.org>
Fri, 25 Sep 2020 05:29:44 +0000 (17:29 +1200)
commitaa06ad4a5f6851a5ffab3de2d2d2dea4bc864f45
tree7c7bcb7f4b39786bba39e984eee8dc54b4b381eb
parent97ff3c552fa4d6125ccbfdfd05dfae0d2e498d3d
[REF] Fix Event location to create it's locations directly rather than via shared methods

This form does extra work in order to call  CRM_Core_BAO_Block::create and CRM_Core_BAO_Address::create - but they have
extra handling that only exists for this code place. So, we are making 2 functions more complex in order to inter-relate them.

This simplifies the CRM_Event_Form_ManageEvent_Location and I will do follow on cleanup once merged. Note I previously
added tests to CRM_Event_Form_ManageEvent_LocationTest specifically to cover this (in a recent previous refactor
CRM/Core/BAO/Location.php
CRM/Core/BAO/Phone.php
CRM/Event/Form/ManageEvent/Location.php
Civi/Api4/LocBlock.php [new file with mode: 0644]
tests/phpunit/CRM/Core/BAO/LocationTest.php
tests/phpunit/CRM/Event/Form/ManageEvent/LocationTest.php
tests/phpunit/api/v3/ACLPermissionTest.php