Alias CRM_Financial_BAO_FinancialTypeAccount -> CRM_Financial_BAO_EntityFinancialAccount
authorColeman Watts <coleman@civicrm.org>
Wed, 23 Nov 2022 16:58:34 +0000 (11:58 -0500)
committerColeman Watts <coleman@civicrm.org>
Wed, 23 Nov 2022 20:21:15 +0000 (15:21 -0500)
commita386fd96f244d3cb7cb53d4902825f0ce978fbed
tree26f7e6fdf5442abd89172c99cd09b61e529d96b0
parent488582ee6980ae9b3ea311a73e0ff74383d451e3
Alias CRM_Financial_BAO_FinancialTypeAccount -> CRM_Financial_BAO_EntityFinancialAccount

This BAO class did not follow the standard naming convention which effectively made it invisible to the API.
Why was named this way in the first place was never explained, I suspect it was simply a mistake.

A BAO class actually did get added before this PR, in 37c608f6e which further added to the confusion.
This consolidates the two classes.

Because it was an "invisible" BAO class, the create and del functions were never used by the API.
For consistency, I've therefore tagged them as @deprecated which keeps them hidden from the API.
We can add business logic back in as needed using hook listeners.
19 files changed:
CRM/Contribute/BAO/Contribution.php
CRM/Core/BAO/OptionValue.php
CRM/Core/CodeGen/GenerateData.php
CRM/Financial/BAO/EntityFinancialAccount.php
CRM/Financial/BAO/FinancialType.php
CRM/Financial/BAO/FinancialTypeAccount.php
CRM/Financial/BAO/PaymentProcessor.php
CRM/Financial/Form/FinancialAccount.php
CRM/Financial/Form/FinancialTypeAccount.php
CRM/Financial/Form/PaymentEdit.php
CRM/Financial/Page/FinancialType.php
CRM/Financial/Page/FinancialTypeAccount.php
tests/phpunit/CRM/Contribute/PseudoConstantTest.php
tests/phpunit/CRM/Core/PseudoConstantTest.php
tests/phpunit/CRM/Financial/BAO/FinancialTypeAccountTest.php
tests/phpunit/CRMTraits/Financial/TaxTrait.php
tests/phpunit/CiviTest/CiviUnitTestCase.php
tests/phpunit/api/v3/ContributionTest.php
tests/phpunit/api/v3/TaxContributionPageTest.php