Send pcp notification only when the contribution is completed
authorEileen McNaughton <emcnaughton@wikimedia.org>
Mon, 7 Jun 2021 03:57:56 +0000 (15:57 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Mon, 7 Jun 2021 05:31:34 +0000 (17:31 +1200)
commita085d22b261a481b561645b0a7124e9845307da7
treecee9a2fb2caae2a7ba6476b09d07c7582e69af6e
parent7b2383efad72f6d0bae5ce708d647e652de6ada9
Send pcp notification only when the contribution is completed

This is a reviewer's cut of https://github.com/civicrm/civicrm-core/pull/19096/
the only substantive difference is the check around the contribution_status_id
in this line https://github.com/civicrm/civicrm-core/pull/19096/files#diff-9f33a2073e9f844dbb842e0737b7df4bce13db31eabe13b9bdd10e1035dbf6d3R612
has had the empty(->contribution_page_id) bit removed - I can
't think why that would be added in & I think it was discussed out but not removed
CRM/Contribute/BAO/Contribution.php
CRM/Contribute/BAO/ContributionSoft.php