CRM-21134 fix enotices in payment processor code assignment.
authoreileen <emcnaughton@wikimedia.org>
Fri, 1 Sep 2017 23:49:00 +0000 (11:49 +1200)
committereileen <emcnaughton@wikimedia.org>
Mon, 18 Sep 2017 21:47:58 +0000 (09:47 +1200)
commit9f7f8a503cf2a8985ce6d0e96a3e25ed922758f8
treee6b560283543b917c71b1e98f8183a9a81acf976
parent1cff4d0c49a4294787cc68e9df4fd11a65ab398d
CRM-21134 fix enotices in payment processor code assignment.

This is generally a code tidy up to push out the principles we have been implementing (ie.
the idea that the processors define their fields. The code can cause e-notices in extensions as is
because it is prescriptive about fields.

I removed the ANDing in the tpl because actually we are not looking to match numbers like 2
2 is the number we have hard-coded for direct debits (we should be using an option group but that
is another story
CRM/Contribute/Form/ContributionBase.php
CRM/Core/Payment.php
templates/CRM/Contribute/Form/Contribution/Confirm.tpl
templates/CRM/Contribute/Form/Contribution/ThankYou.tpl