Revert "Remove unreachable code lines."
authoreileen <emcnaughton@wikimedia.org>
Wed, 5 Feb 2020 05:12:54 +0000 (18:12 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 5 Feb 2020 05:12:54 +0000 (18:12 +1300)
commit95f7b3ae2a27874011f17ee92dfc2a09b6009ce5
tree8b6ff9d2dbe0e96d749b9e0735f315bb237a1d9e
parent3f4b536ae5d18063aa3220052b3c77cf801a9ba8
Revert "Remove unreachable code lines."

In the course of https://github.com/civicrm/civicrm-core/pull/16462
I concluded that there might be (untested scenarios) where this would still be hit.

In #16462 I adopted a cleaner (tested) approach. However, I think it's unlikely that
will be merged before 5.23 is cut so I propose reverting this change & re-reverting it
once the rc is cut as a more conservative approach. We can focus on getting #16462
wrapped up for 5.24

This reverts commit d7943ca7f7107c1466e687e876bddaf0f1998d99.
CRM/Contribute/BAO/Contribution.php
CRM/Contribute/Form/Task/Invoice.php