FiveFortyNine - Don't munge soft credit 'limit-to'
authorTim Otten <totten@civicrm.org>
Wed, 18 May 2022 22:02:12 +0000 (15:02 -0700)
committerTim Otten <totten@civicrm.org>
Thu, 19 May 2022 02:23:35 +0000 (19:23 -0700)
commit956bf414e942f8553f04eb145e2ac3daedb98d61
tree34ca201694efbdb2c5850bc30dd511c7f943fbc1
parent8c9dec12d98f9caffc43c23eaa0bc5fa5d25857d
FiveFortyNine - Don't munge soft credit 'limit-to'

I'm not sure what it even means to limit a scheduled-reminder to a "soft_credit_type".

But it's a thing - I can use the 5.48 GUI to create it. Here's how it looks in the DB (in 5.48):

+----+------------------------------------------+------------------+----------+------------------+-------------------+----------+
| id | title                                    | recipient        | limit_to | recipient_manual | recipient_listing | group_id |
+----+------------------------------------------+------------------+----------+------------------+-------------------+----------+
| 11 | Limit To - Soft Credit                   | soft_credit_type |        1 | NULL             | in_memory_of      |     NULL |
+----+------------------------------------------+------------------+----------+------------------+-------------------+----------+

The `changeBooleanColumnLimitTo()` was coercing down to `limit_to=null` because it lacked `recipient_manual` and `group_id`.
CRM/Upgrade/Incremental/php/FiveFortyNine.php