Remove addressee, email_greeting_id, postal_greeting_id from exposed tokens
authoreileen <emcnaughton@wikimedia.org>
Thu, 11 Mar 2021 08:57:29 +0000 (21:57 +1300)
committereileen <emcnaughton@wikimedia.org>
Thu, 11 Mar 2021 12:50:02 +0000 (01:50 +1300)
commit94cb957cd539033c6ccfb9c250a0cecf0c7f1ea6
tree999ccb1c8e9a8c6c502d9a4b9e1f549e3b79bc51
parentd13f7a7028b4eb93d4c0f36c3a0b0a206160f7e6
Remove addressee, email_greeting_id, postal_greeting_id from exposed tokens

Per discussion on https://github.com/civicrm/civicrm-core/pull/19550#issuecomment-781597319
there appears to be agreement that supporting tokens like
addressee_id (which resolves to '{contact.individual_prefix}{ }.....')
should not be exposed / supported as they seem both unuseful and likely
to be breaky.

These were exposed unintentionally as part of a change to make them
available as WHERE filters on apiv3
https://github.com/civicrm/civicrm-core/commit/54e389ac6565ff534b87e5e46137a57d48d6c5c8

The discussion suggests that by contrast we should
add support to hash in the token compat subscriber
CRM/Core/SelectValues.php
tests/phpunit/CRM/Core/BAO/MessageTemplateTest.php