Fix notice on is_quick_config
authorEileen McNaughton <emcnaughton@wikimedia.org>
Fri, 10 Nov 2023 03:41:00 +0000 (16:41 +1300)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Fri, 10 Nov 2023 03:54:02 +0000 (16:54 +1300)
commit93647195726ba2e42fc5fabca05b5e3d3ef3da05
treec4dbafee6a65bc1ee858804369fbc29a7fc4e238
parentc75ddca22227b540b535fb376c4eb6f5fbfbcd9f
Fix notice on is_quick_config

is_quick_config is only assigned when a payment is being made on an existing
contribution - this was a bit hard to figure out so I switched to using
a variable that explicitly says what it means (rather than guess at ccid)
and ensured that is_quick_config was only accessed within these blocks

Also, I pulled the assignment on the Dummy processor name from out of
the unrelated function
CRM/Contribute/Form/Contribution/Main.php
templates/CRM/Contribute/Form/Contribution/Main.tpl
templates/CRM/Contribute/Form/Contribution/MainMembershipBlock.tpl