checksum_timeout - Use consistent naming
authorTim Otten <totten@civicrm.org>
Thu, 20 Aug 2015 11:14:04 +0000 (04:14 -0700)
committerTim Otten <totten@civicrm.org>
Thu, 17 Sep 2015 22:45:00 +0000 (15:45 -0700)
commit92a8de72967da0e63f6a8f0f93c78149b8fe9463
tree54ccd59304d8e4efe1a0012e6583f6e434a6cdc8
parentd356cdebdaa45a3479eda021de7b17260f748fae
checksum_timeout - Use consistent naming

This was a weird one:

 * The admin form rendered HTML element "checksumTimeout" but saved setting "checksum_timeout", which required workarounds.
 * The runtime code read the setting as "checksum_timeout".
 * The metadata defined setting "checksumTimeout". `prefetch` is enabled, but there's no `config_key` or `legacy_key`.

I believe this means that the runtime and admin form worked (because they
agreed that the name was "checksum_timeout"), but the Setting API would not
work (because it used "checksumTimeout").

This revision standardizes on "checksum_timeout" on the theory that
"checksum_timeout" was the actual value used at runtime. This means:

 * If you had configured the form and had it working correctly, it should
   still work correctly.
 * If you had a script to set "checksumTimeout" via API, then it wasn't
   working before, and it's still not working now.
CRM/Admin/Form/Setting.php
CRM/Admin/Form/Setting/Miscellaneous.php
CRM/Contact/BAO/Contact/Utils.php
CRM/Core/BAO/ConfigSetting.php
settings/Core.setting.php
templates/CRM/Admin/Form/Setting/Miscellaneous.tpl