Decommission recordPartialPayment function
authoreileen <emcnaughton@wikimedia.org>
Fri, 21 Jun 2019 21:50:40 +0000 (17:50 -0400)
committereileen <emcnaughton@wikimedia.org>
Fri, 21 Jun 2019 21:53:36 +0000 (17:53 -0400)
commit88a20030a42b4bdc5592894bb37624fd876f3739
tree61bccbbf427343b7cabec899e3355eee6a7ac96c
parenta2c5de48ef39418b05f9f4f6e71c1ed61f27861b
Decommission recordPartialPayment function

While I would normally say extracting is good sometimes if feels like things are being broken down in the
wrong places. In this case I think the function name is misleading and having this in the body of Payment.create
makes the path to cleaning up that function clearer
CRM/Contribute/BAO/Contribution.php
CRM/Financial/BAO/Payment.php
tests/phpunit/CRM/Core/BAO/FinancialTrxnTest.php