Remove unused and largely unreachable code.
authoreileen <emcnaughton@wikimedia.org>
Thu, 9 Jan 2020 02:11:22 +0000 (15:11 +1300)
committereileen <emcnaughton@wikimedia.org>
Thu, 9 Jan 2020 02:18:11 +0000 (15:18 +1300)
commit8372e6054a3f3eb159de85bc40cd81f023d5cbb1
tree084bf85a401bd9af412fc864488e49484663cf0e
parentf0be7552105c404ee068bcaabc811180c4d45bb6
Remove unused and largely unreachable code.

The removed lines can only be reached if
a) CMS is Joomla or
b) CMS is Drupal and NULL is not equal to NULL

This seemed a little suspicious - especially since the merge screen still does display the value that should
be but isn't calculated here. After digging I found it is duplicated here
https://github.com/civicrm/civicrm-core/blob/bc77d7c0798081f999e6eca92d75fa874fd04e74/CRM/Contact/Form/Merge.php#L115
and that is the value used in the tpl here
https://github.com/civicrm/civicrm-core/blob/1188c7a8512382b1cb588b6a1ea4b13aa9587bc9/templates/CRM/Contact/Form/Merge.tpl#L217

so these lines can be safely removed as redundant. I also signposted where I think the next cleanups should happen on this
with code comments
CRM/Contact/Form/Merge.php
CRM/Dedupe/Merger.php