[REF] Stop passing contributionPageID to isEmailReceipt
authoreileen <emcnaughton@wikimedia.org>
Tue, 2 Feb 2021 01:15:25 +0000 (14:15 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 3 Feb 2021 00:43:50 +0000 (13:43 +1300)
commit82b1ec8f97049843b2edc4d773cbb2623bf70919
treea6b95eb2d05008652b69eb80a5e0d72f2bd06f4a
parent995bab0ca21003aa85c962052ad0ff28f2af02c6
[REF] Stop passing contributionPageID to isEmailReceipt

By switching to passing in contributionID instead we can significantly simplify this.

It could cause an extra query in some cases but the query would be very quick based
on my previous query reduction efforts and this will help us
remove a bunch of other code
CRM/Contribute/BAO/Contribution.php
tests/phpunit/api/v3/ContributionPageTest.php