[REF] Remove apparent copy & paste code.
authoreileen <emcnaughton@wikimedia.org>
Fri, 17 Jan 2020 00:34:44 +0000 (13:34 +1300)
committereileen <emcnaughton@wikimedia.org>
Fri, 17 Jan 2020 00:38:04 +0000 (13:38 +1300)
commit804beb78d22830ffdfb702bff0637f5b0cfb15f6
treebca4503ccd24c69221b35a44ef019ad0379a6e76
parent485fd59ce422afe392640a46d8ed7f288ffc2fba
[REF] Remove apparent copy & paste code.

In code familiarisation to tackle dev#core/1217 I looked at this var & concluded that the var is set in 9
places but in 8 of those it is never used. In the last place (CRM_Contact_Form_Search) it is used to
determine whether to build the pre-next cache. I swapped it over to just doing a getButton without any
change - I stepped through in advanced search, search builder, custom search, basic search it still enters the cache lines of code. In Contribution, event search it doesn't (before & after).

Part of just makingg code semi-readable
CRM/Activity/Form/Search.php
CRM/Campaign/Form/Search.php
CRM/Case/Form/Search.php
CRM/Contact/Form/Search.php
CRM/Contribute/Form/Search.php
CRM/Core/Form/Search.php
CRM/Event/Form/Search.php
CRM/Grant/Form/Search.php
CRM/Member/Form/Search.php
CRM/Pledge/Form/Search.php