[REF] Move membership date calc from v3 api to BAO
authorEileen McNaughton <emcnaughton@wikimedia.org>
Mon, 24 May 2021 08:29:08 +0000 (20:29 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Sat, 3 Jul 2021 23:26:04 +0000 (11:26 +1200)
commit7670664eb520a15ed3322a8bd4be6758c47b331c
tree174dee728d2bcedecf3f17d8276d9cd30ac4a530
parent02ef1a69ca22ff6d12b2fef9d856669bce1fed55
[REF] Move membership date calc from v3 api to BAO

This moves code to calculate membership dates for new memberships from the
v3 api Membership.create and the batch entry membership form to the membership bao.

I think more cleanup could follow this - in the api most obviously and
the BAO is a bit insane still

This has test cover in the v3 api membership test and in
CRM_Batch_Form_EntryTest
CRM/Batch/Form/Entry.php
CRM/Member/BAO/Membership.php
api/v3/Membership.php
tests/phpunit/api/v3/MembershipTest.php