Refactored ParticipantListing.php
authorJohnFF <john@futurefirst.org.uk>
Fri, 13 Jun 2014 23:25:55 +0000 (00:25 +0100)
committerJohnFF <john@futurefirst.org.uk>
Fri, 13 Jun 2014 23:25:55 +0000 (00:25 +0100)
commit7621050bb932f0fde6e52f05290feafecc26ce47
tree50f7b7d978d00ce02f038f61af7afeff49f5ff4c
parent46c930a638afbd4cc01e60936006faf01ccc5edc
Refactored ParticipantListing.php

1) Commuted assigns in if statements into assigning, then checking, as otherwise fails code validators and breaches CiviCRM coding conventions.

2) Refactored repeated code found while repairing those errors into a separate reusable function that accepts parameters. I only did this where the code was identical. Where there was any distinction I didn't do this to prevent introducing bugs.

https://issues.civicrm.org/jira/browse/CRM-14434
CRM/Report/Form/Event/ParticipantListing.php