dev/core#2073 Fix use of legacy leaky method in tested code
authoreileen <emcnaughton@wikimedia.org>
Wed, 7 Oct 2020 20:22:22 +0000 (09:22 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 7 Oct 2020 20:23:01 +0000 (09:23 +1300)
commit75511053cd9dac5f14a936d3589279e75eb70d41
tree1e72918d970b9e904dc7d18fb8dcb5c6867a4d9f
parent97240a74c1e9193627deed4309e0dadc5588cd16
dev/core#2073 Fix use of legacy leaky method in tested code

Overview
----------------------------------------
Fix use of legacy leaky method in tested code

Before
----------------------------------------
dao->query()

After
----------------------------------------
CRM_Core_DAO::executeQuery()

Technical Details
----------------------------------------
This is too low volume to really leak but it uses the leaky legacy method and
has test cover in

CRM_Contact_Page_View_UserDashboard_GroupContactTest.testBrowseDisplaysCorrectListOfAddedGroups
CRM_Contact_Page_View_UserDashboard_GroupContactTest.testBrowseDisplaysCorrectListOfAVailableGroups
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentEmptyContact
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentContributionsWithInvoicingEnabled
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentContributions

----------------------------------------
CRM/Contact/BAO/GroupContact.php