Fix inconsistent handling when searching contribution text fields
authoreileen <emcnaughton@wikimedia.org>
Sun, 26 May 2019 23:57:09 +0000 (11:57 +1200)
committereileen <emcnaughton@wikimedia.org>
Mon, 27 May 2019 22:01:26 +0000 (10:01 +1200)
commit7123f88c5383a5d6c4fcae98e0587ccf562a2db3
treeb48292ece961150af2ed1c74b19bcac4f56e7cce
parent3990fbed1568b87039f7e007d61f91cc1668d713
Fix inconsistent handling when searching contribution text fields

I found that if you search on contribution source it adds wildcards & uses 'like' but with cancel_reason not
so much.

I found that for contribution_source there was field-specific hacky handling, so I converted both fields
to be metadata based and added handling for string fields on the form layer
CRM/Contribute/BAO/Query.php
CRM/Contribute/Form/Search.php
CRM/Core/Form/Search.php