projects / civicrm-core.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: be5d92d) | patch
[REF] improve function signature on updateFinancialAccountsOnContributionStatusChange
authoreileen <emcnaughton@wikimedia.org>
Thu, 10 Oct 2019 08:16:28 +0000 (10:16 +0200)
committereileen <emcnaughton@wikimedia.org>
Fri, 11 Oct 2019 17:48:34 +0000 (06:48 +1300)
commit666f314b9b52d751f1db86adf1eb3a11d0c11b0c
tree42b23203486bb873ee8f0d63e91b032443a8c689tree | snapshot (zip tar.gz)
parentbe5d92d72e487011ed6767495047ecb2cc061357commit | diff
[REF] improve function signature on updateFinancialAccountsOnContributionStatusChange

This private function is only called from one place. The conditional before it is called is
if ($context == 'changedStatus') {

Ergo $context is ALWAYS changedStatus when this function is called.

As a result I have removed context from the function signature & the if that checks it is
equal to 'changedStatus'
CRM/Contribute/BAO/Contribution.php diff | blob | blame | history