Fix campaign_id handling for batch entry
authoreileen <emcnaughton@wikimedia.org>
Mon, 19 Oct 2020 02:23:57 +0000 (15:23 +1300)
committereileen <emcnaughton@wikimedia.org>
Sun, 25 Oct 2020 21:15:32 +0000 (10:15 +1300)
commit5fbbde1ffbe356e2b53eb2ac3deb22fb0a690f1b
tree6d0b852dc0bbda8272095b8b2ccd808d215bda85
parent687c869f0304d889d41abf46f22d8b5730227508
Fix campaign_id handling for batch entry

Fixes a bug whereby campaign_id is not updated on batch entry if it has been added to the profile.

The underlying issue appears to be an  attack of copy and paste. I tidied up the variable
in both the places that call the processMembership function such that it is passed in
as an array of pass-through params. The function can be simplified & eventually removed.
CRM/Batch/Form/Entry.php
CRM/Contribute/Form/Contribution/Confirm.php
CRM/Member/BAO/Membership.php
tests/phpunit/CRM/Batch/Form/EntryTest.php
tests/phpunit/CRM/Member/BAO/MembershipTest.php