[REF] Simplify array construction
authorColeman Watts <coleman@civicrm.org>
Thu, 10 Sep 2020 15:39:25 +0000 (11:39 -0400)
committereileen <emcnaughton@wikimedia.org>
Fri, 11 Sep 2020 20:05:07 +0000 (08:05 +1200)
commit5f0a0a71ae47507556fe735f13c9a37b270a20db
tree8a974a53fb38ba7f03e85ea3ab04335956abb5ba
parentfd364ea9b9bf04949e17b6f735b8f8367e0ce70b
[REF] Simplify array construction

In trying to interpret https://github.com/civicrm/civicrm-core/pull/17992

I realised that the code copies values from the dao to an array, copies the array
to another array, unsets most of the variables and then uses that second array.

This simplifies.

The easiest way to work through this code is in a debugger running

testProcessMembershipUpdateStatus
CRM/Member/BAO/Membership.php