CRM-20600 - Civi\Angular\Manager::getStrings() - Scan raw HTML strings instead of...
authorTim Otten <totten@civicrm.org>
Tue, 16 May 2017 05:29:07 +0000 (22:29 -0700)
committerTim Otten <totten@civicrm.org>
Sat, 17 Jun 2017 02:03:47 +0000 (19:03 -0700)
commit53d0084104da7d8b842e2385a12805e212c1542f
tree4ea6f382bcd04d2528d2e88665e4aff7af044d0d
parentd1e4cc3f4e0e64b162b11bdce2c36d6724675e2a
CRM-20600 - Civi\Angular\Manager::getStrings() - Scan raw HTML strings instead of *.html files

Rationale: If the raw HTML can be modified via hook, then the HTML files are
not truly representative of the final output.  (e.g.  a hook might add a new
string to some HTML.)

Note: This patch means that we no longer benefit from the cache in
`CRM_Core_Resources_Strings`.  However, the typical user still pulls data
from a cache because we're using `AssetBuilder` to manage
`angular-modules.json`.

Note: `getStrings()` now requires a call to `getPartials()`, which is
expected to become more expensive (firing a hook).  To avoid building the
partials twice, we introduce a private cache.
Civi/Angular/Manager.php