Cleanup tracking on group.load
authorEileen McNaughton <emcnaughton@wikimedia.org>
Sat, 15 May 2021 01:27:08 +0000 (13:27 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Mon, 17 May 2021 01:13:29 +0000 (13:13 +1200)
commit4f39b1e67a6b56ba6fd6addfdc12f8991fb8130f
tree562daff016ebae11e2cfb97d68789371cf70a23a
parent966fbbea58ba3f26c8c580c250074bd201822728
Cleanup tracking on group.load

1) deprecate force parameter
2) ditch the static & let the db lookups speak for themselves

The force paramter seems to mostly be about the static & probably only exists to support tests.
The static doesn't make sense now because either they group needs loading or it doesn't.
The fact the process might have tried and succeeded or failed before doesn't need
to be recorded in the static

Cleanup up progress tracking in Group::load

Fix test to do things in a logical order so contacts exist when the group is created
CRM/Contact/BAO/GroupContactCache.php
tests/phpunit/CRM/Contact/BAO/GroupContactCacheTest.php
tests/phpunit/CRM/Contact/BAO/GroupTest.php
tests/phpunit/CRM/Contact/BAO/QueryTest.php
tests/phpunit/CRM/Group/Page/AjaxTest.php
tests/phpunit/CRM/Mailing/BAO/MailingTest.php