[REF] Add test for existing Participant batch update cancel and fix to not call BaseI...
authoreileen <emcnaughton@wikimedia.org>
Wed, 2 Sep 2020 06:43:08 +0000 (18:43 +1200)
committereileen <emcnaughton@wikimedia.org>
Wed, 2 Sep 2020 06:43:08 +0000 (18:43 +1200)
commit4eba8926824dac77b94659cd1a25ea4c57b5fd53
tree67d9cfa856c03638b0695d8229f6c7290bf4d8f0
parent40907409ee67ed8dc1b186995af54040f3555ef4
[REF] Add test for existing Participant batch update cancel and fix to not call BaseIPN->cancelled

I dug into what is 'achieved' by calling BaseIPN->cancelled here and everything except the bit where the contribution
is updated to cancelled is actually bypassed so a simple api call suffices.

I also discovered the cancellation of the contribution is highly conditional and arguably illogical. I will separately
log a gitlab to discuss whether it still makes sense, but I wouldn't want that discussion to derail this
no-change cleanup
CRM/Core/Payment/BaseIPN.php
CRM/Event/Form/Task/Batch.php
tests/phpunit/CRM/Event/Form/Task/BatchTest.php
tests/phpunit/CRMTraits/Financial/OrderTrait.php