CRM_Utils_File::absoluteDirectory() - Make `$basePath` required
authorTim Otten <totten@civicrm.org>
Wed, 10 Jul 2019 06:32:10 +0000 (23:32 -0700)
committerTim Otten <totten@civicrm.org>
Wed, 10 Jul 2019 06:32:10 +0000 (23:32 -0700)
commit47ec65476157c6d3b0c3e0b6d4ae88907e15c046
treeb3bf3fec3d946c26a14da20c8e4ffe900a85d39e
parentcc722349d95082b999575fe7da1796e03450fd12
CRM_Utils_File::absoluteDirectory() - Make `$basePath` required

Previous versions interpreted `$basePath=NULL` to mean "default to `self::baseFilePath()`".
However, no code in the known `universe` relies on this interpretation, and
the `baseFilePath()` function is problematic/deprecated.

We could almost deprecate the entire function `absoluteDirectory()`;
however, it's fine to keep around: the semantics are reasonable if one
provides `$basePath`, and there is one active use-case in which
`Civi\Core\Paths` calls `absoluteDirectory()` with a suitable `$basePath`.
CRM/Utils/File.php