projects / civicrm-core.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e8470bf) | patch
SearchKit - Fix broken group-by caused by non-aggregated id column
authorColeman Watts <coleman@civicrm.org>
Thu, 31 Mar 2022 13:42:42 +0000 (09:42 -0400)
committerColeman Watts <coleman@civicrm.org>
Thu, 31 Mar 2022 13:57:11 +0000 (09:57 -0400)
commit4775ec6f46c14c550b7d6a9870c16bc9b0b6d599
treed220ea2e5938377915287dab09c273ce61ce4323tree | snapshot (zip tar.gz)
parente8470bffde77cd531605454950f218e6afac3768commit | diff
SearchKit - Fix broken group-by caused by non-aggregated id column

Before: The `id` column was being unconditionally added, breaking FULL_GROUP_BY sql
After: Let the Api4SelectQuery take care of it for DAO entities
ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php diff | blob | blame | history
ext/search_kit/tests/phpunit/api/v4/SearchDisplay/SearchRunTest.php diff | blob | blame | history