(NFC) SchemaStructure.php - Fix up mismatch between stored+generated code
authorTim Otten <totten@civicrm.org>
Sat, 13 Apr 2019 20:19:09 +0000 (13:19 -0700)
committerTim Otten <totten@civicrm.org>
Sat, 13 Apr 2019 20:19:09 +0000 (13:19 -0700)
commit3eb2aab1793f8be83c4a3c3b153c15be8399d422
tree9e65da01d173ed4a65dcbaf6f2319ce0f5f80470
parentc364957e71dd780bf53dc65e0cf4ea10187b4417
(NFC) SchemaStructure.php - Fix up mismatch between stored+generated code

Overview
--------

The class `CRM_Core_I18n_SchemaStructure` is autogenerated via GenCode, and it is also commited to git.
The two forms don't match because of the recent code-style cleanup.

Before
------

After running GenCode, there appears to be uncommitted changes in `CRM_Core_I18n_SchemaStructure`.
The changes indicate a reversion in code-style (e.g. `null` vs `NULL`; some whitespace).

After
-----

GenCode produces output which matches the recent cleanup.

Comments
--------

Fixing `null` / `NULL` was easy. However, the whitespace mismatch was more subtle -- because the
`PHP_Beautifier` was messing it up. To resolve, I disabled `PHP_Beautifier` for this file, and fixed
the underlying templates to generate well-formed code.

The output of the process matches the existing code; therefore, the change
have no functional impact (NFC).  You can see this by running `setup.sh` and
checking the `git status`.
CRM/Core/CodeGen/I18n.php
xml/templates/schema_structure.tpl