[REF] Cleanup validation in PaypalProIPN single function
authorEileen McNaughton <emcnaughton@wikimedia.org>
Thu, 20 May 2021 03:50:37 +0000 (15:50 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Thu, 20 May 2021 03:50:37 +0000 (15:50 +1200)
commit3d11a1e8ebb15a5a0cbc21dae25b0c854fd473c9
tree8bf13b0dbcf0e6954d3f0e0e980e84a639f4dffd
parentca23a44aebfd04f5c179026edf92d9d366fbf305
[REF] Cleanup validation in PaypalProIPN single function

This fixes interaction with the contribution object to instead use the function
and switches the standardised error handling (throw an exception & let
it be caught).

The contribution object used to be passed to completeOrder but no longer
so there is no reason to set total_amount & invoice_id on it
(they will be used from input)
CRM/Core/Payment/PayPalProIPN.php