dev/core#562 Remove more DAO->free() calls
authoreileen <emcnaughton@wikimedia.org>
Tue, 16 Apr 2019 21:12:22 +0000 (07:12 +1000)
committereileen <emcnaughton@wikimedia.org>
Tue, 16 Apr 2019 21:12:22 +0000 (07:12 +1000)
commit3afe475309fde9f4b7437e424f924e94f0764056
treef6133118c532dc2bfd473bcc09d201427c7cbb97
parentff2c44653d8090a79d339863a0f252a3123936c9
dev/core#562 Remove more DAO->free() calls

We have been removing a few of these each release. They no longer provide any benefit
as the resources are released in the deconstructor. OTOH they can in rare circumstances cause bugs.

Previous removals have not caused any issues so the slow approach is starting to
look overly cautious now
20 files changed:
CRM/Admin/Form/ScheduleReminders.php
CRM/Contact/BAO/Contact.php
CRM/Contact/BAO/Contact/Utils.php
CRM/Contact/BAO/ContactType.php
CRM/Contact/BAO/Group.php
CRM/Contact/BAO/Relationship.php
CRM/Contact/BAO/RelationshipType.php
CRM/Contact/Form/DedupeRules.php
CRM/Contact/Form/Task.php
CRM/Contact/Import/Parser/Contact.php
CRM/Contribute/Form/AbstractEditPayment.php
CRM/Contribute/Form/Task.php
CRM/Dedupe/BAO/RuleGroup.php
CRM/Dedupe/Merger.php
CRM/Mailing/BAO/TrackableURL.php
CRM/Mailing/Event/BAO/Delivered.php
CRM/Mailing/Event/BAO/Subscribe.php
CRM/Report/Form.php
CRM/Report/Form/Contribute/History.php
Civi/Core/SettingsBag.php