Stop adding a refund payment from creating extraneous financial items
authoreileen <emcnaughton@wikimedia.org>
Tue, 27 Aug 2019 07:07:39 +0000 (19:07 +1200)
committereileen <emcnaughton@wikimedia.org>
Tue, 3 Sep 2019 12:07:17 +0000 (00:07 +1200)
commit36057c8dc60fbc86ced9cd49b056521b21de16ef
treef707dfa4e4fcd8ed384662dd76afc9005279afc9
parente0b4778b6ed7068d1940998d071a74a7d9236df0
Stop adding a refund payment from creating extraneous financial items

Per
https://github.com/civicrm/civicrm-core/pull/15143#issuecomment-527245150

and https://github.com/civicrm/civicrm-core/pull/13114/files#diff-8967f6e57d6209aa277ded6512413608L326
it seems agreed the financial items should not be created on refund.

This removes them & updates the test
CRM/Financial/BAO/Payment.php
tests/phpunit/api/v3/PaymentTest.php