Fix for non-allocation of payment to fully reversed checkboxes option
authoreileen <emcnaughton@wikimedia.org>
Wed, 6 Nov 2019 04:51:20 +0000 (17:51 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 6 Nov 2019 04:51:20 +0000 (17:51 +1300)
commit32ecba8e5830619359c7ceb1db807acdec8cac8d
treedaab6cc7a550969f494122070b9d275dc262112b
parentbdde6b87f40b83b5b67ead756b40a51134aa8a8c
Fix for non-allocation of payment to fully reversed checkboxes option

This addresses an issue partially identified in https://lab.civicrm.org/dev/financial/issues/98 whereby
civicrm_entity_financial_trxn records for the civicrm_financial_item table are not created when
refunding against line items with a quantity of zero  - ie where there were selected checkboxes & they
were reversed.

The reason this check was there relates to former logic - now we have a calculated allocation
we don't need this check.

I want to do a test but need to do a bit of work to get it set up & I think this should hit 5.20
as it relates to an issue identified by Kevin in reviewing patches merged to that version
CRM/Financial/BAO/Payment.php