CRM-14221 - Improving Payment Express/DPS payment processor strict standards compatib...
authorMatt Renner <matt@rennernz.com>
Fri, 14 Feb 2014 03:49:50 +0000 (16:49 +1300)
committerMatt Renner <matt@rennernz.com>
Fri, 14 Feb 2014 03:49:50 +0000 (16:49 +1300)
commit328b8a19a9032df375bdee43e0c0ce1594fabe92
tree76faea265468ca1792bca80639e8b17c458551ad
parentfac14a5c5e0f267d1df084081bdd80c37a9e9875
CRM-14221 - Improving Payment Express/DPS payment processor strict standards compatibility

I'm running a fairly recent version of PHP, and have strict standards turned on.. so the Payment Express component was spewing warnings and errors about non-static functions being called statically and the singleton function not being compatible with its parent.

The solution, make the CRM_Core_Payment_PaymentExpressUtils functions static, and change the definition of the CRM_Core_Payment_PaymentExpress and CRM_Core_Payment_PaymentExpressIPN singleton() functions to match that in CRM_Core_Payment

I also discovered an undefined CURL option in CRM_Core_Payment_PaymentExpressUtils that was being set - This doesn't do anything and causes a warning so I removed it.
CRM/Core/Payment/PaymentExpress.php
CRM/Core/Payment/PaymentExpressIPN.php
CRM/Core/Payment/PaymentExpressUtils.php