Simply buildMembershipTypeValues & access cached values
authoreileen <emcnaughton@wikimedia.org>
Mon, 9 Dec 2019 09:29:09 +0000 (22:29 +1300)
committereileen <emcnaughton@wikimedia.org>
Thu, 2 Jan 2020 22:01:28 +0000 (11:01 +1300)
commit322b59f00ce2917cef8c3b1b56dd57540fb9ede2
tree5e257bd048abcf6293a2b6067d16930fee61df90
parent0b0775b2d5b712a91946bd5067915eebe871edb3
Simply buildMembershipTypeValues & access cached values

This simplifies this function & switches it to use a cached function to get the MembershipTypes. In general I would
argue that we should be caching metadata entities (membership types, statues, price fields, etc) and accessing
the cached versions & ideally the v4 api would be able to access cached versions filter-dependent.

In order to keep the test passing I worked a little on standardisation
CRM/Core/Config.php
CRM/Member/BAO/Membership.php
CRM/Member/BAO/MembershipType.php
tests/phpunit/CRM/Member/BAO/MembershipTest.php