Fix self-service recurring link on dashboard
authoreileen <emcnaughton@wikimedia.org>
Mon, 3 May 2021 05:18:12 +0000 (17:18 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Mon, 17 May 2021 02:25:24 +0000 (14:25 +1200)
commit2d852c615d673da119a5cd598d5f8af79c9f902c
treef2810ca15246ed26184b476238d85fcfeddb96e6
parentf3388b789c5b30626ee1252d54aaa54478c1fa8e
Fix self-service recurring link on dashboard

This picks up on two of the issues that were blocking on
https://github.com/civicrm/civicrm-core/pull/18787 and
https://github.com/civicrm/civicrm-core/pull/18196
(but does not solve all of them). It

1) adds the basis for unit test cover and
2) separates the function for retrieving links
for self-service from back office user.

I think there is still some jumbling together of these concepts but
as long as we are careful to extend the tests as we extend the logic...

This fixes what I suspect is an oldish regression whereby the cancel link
for paypal std users was wrong
CRM/Contribute/Page/Tab.php
CRM/Contribute/Page/UserDashboard.php
CRM/Core/Session.php
CRM/Member/Page/RecurringContributions.php
tests/phpunit/CRM/Contribute/Page/TabTest.php