projects / civicrm-core.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 47b46fe) | patch
[REF] Fix CRM_Core_BAO_UFGroup::createUFJoin to not receive by reference.
authoreileen <emcnaughton@wikimedia.org>
Thu, 9 Jan 2020 20:57:10 +0000 (09:57 +1300)
committereileen <emcnaughton@wikimedia.org>
Fri, 17 Jan 2020 20:11:13 +0000 (09:11 +1300)
commit259ab0311a5d3279af90f6583a01a369603f5338
treeb461263defd1a14db7807033bfedc36f2769513atree | snapshot (zip tar.gz)
parent47b46febe6b0f15beebce027a9442a8003ef1ad5commit | diff
[REF] Fix CRM_Core_BAO_UFGroup::createUFJoin to not receive by reference.

This function is called from one place. It gets passed a params variable that is 're-used' so this
change makes it clear what actually needs to be passed on. We have an anti-pattern in our code whereby params get
passed all sorts of places with it being confusing which ones actually need to receive what
CRM/Core/BAO/UFGroup.php diff | blob | blame | history
CRM/UF/Form/Group.php diff | blob | blame | history